linux-kernel - Re: [PATCH] mmotm: mm-oom-fortify-task_will_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160629192232.GA19097@redhat.com>
Date:	Wed, 29 Jun 2016 21:22:33 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Michal Hocko <mhocko@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	Vladimir Davydov <vdavydov@...allels.com>,
	David Rientjes <rientjes@...gle.com>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>,
	Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix

On 06/29, Michal Hocko wrote:
>
> But it seems that further changes I am
> planning in this area will benefit from stable task->mm in this path

Oh, so I hope you will cleanup this later,

> Just pull the task->mm !=
> NULL check inside the function.

OK, but this means it will always return false if the task is a zombie
leader.

I am not really arguing and this is not that bad, but this doesn't look
nice and imo asks for cleanup.

Oleg.