linux-kernel - Re: [Y2038] [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4878160.cRxJJ9CCsj@wuerfel>
Date:	Wed, 29 Jun 2016 21:48:02 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	y2038@...ts.linaro.org
Cc:	Deepa Dinamani <deepa.kernel@...il.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	shaggy@...nel.org, jfs-discussion@...ts.sourceforge.net,
	trond.myklebust@...marydata.com, clm@...com,
	adilger.kernel@...ger.ca, tglx@...utronix.de, zyan@...hat.com,
	paul@...l-moore.com, sage@...hat.com, idryomov@...il.com,
	linux-ext4@...r.kernel.org, cm224.lee@...sung.com,
	mfasheh@...e.com, john.stultz@...aro.org, viro@...iv.linux.org.uk,
	dsterba@...e.com, jaegeuk@...nel.org, ceph-devel@...r.kernel.org,
	linux-nfs@...r.kernel.org, elder@...nel.org, tytso@....edu,
	dedekind1@...il.com, jbacik@...com, gregkh@...uxfoundation.org,
	adrian.hunter@...el.com, eparis@...hat.com,
	linux-f2fs-devel@...ts.sourceforge.net, sfrench@...ba.org,
	linux-audit@...hat.com, ocfs2-devel@....oracle.com, jack@...e.com,
	linux-mtd@...ts.infradead.org, lustre-devel@...ts.lustre.org,
	torvalds@...ux-foundation.org, anna.schumaker@...app.com,
	linux-btrfs@...r.kernel.org, jlbec@...lplan.org
Subject: Re: [Y2038] [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time()

On Saturday, June 25, 2016 2:37:24 PM CEST Deepa Dinamani wrote:
> The series is aimed at getting rid of CURRENT_TIME, CURRENT_TIME_SEC macros
> and replacing current_fs_time() with current_time().
> The macros are not y2038 safe. There is no plan to transition them into being
> y2038 safe.
> ktime_get_* api's can be used in their place. And, these are y2038 safe.
> 
> CURRENT_TIME will be deleted after 4.8 rc1 as there is a dependency function
> time64_to_tm() for one of the CURRENT_TIME occurance.
> 
> Thanks to Arnd Bergmann for all the guidance and discussions.
> 
> Patches 3-5 were mostly generated using coccinelle.
> 
> All filesystem timestamps use current_fs_time() for right granularity as
> mentioned in the respective commit texts of patches. This has a changed
> signature, renamed to current_time() and moved to the fs/inode.c.
> 
> This series also serves as a preparatory series to transition vfs to 64 bit
> timestamps as outlined here: https://lkml.org/lkml/2016/2/12/104 .
> 
> As per Linus's suggestion in https://lkml.org/lkml/2016/5/24/663 , all the
> inode timestamp changes have been squashed into a single patch. Also,
> current_time() now is used as a single generic vfs filesystem timestamp api.
> It also takes struct inode* as argument instead of struct super_block*.
> Posting all patches together in a bigger series so that the big picture is
> clear.
> 
> As per the suggestion in https://lwn.net/Articles/672598/, CURRENT_TIME macro
> bug fixes are being handled in a series separate from transitioning vfs to use.
> 

Everything in this version looks good to me. Please add

Reviewed-by: Arnd Bergmann <arnd@...db.de>

and send a pull request to Al Viro, based on the latest linux-4.7-rc release.

	Arnd