linux-kernel - [PATCH 1/2] fs: befs: check silent flag before logging error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1467232061-5600-1-git-send-email-luisbg@osg.samsung.com>
Date:	Wed, 29 Jun 2016 21:27:40 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	linux-kernel@...r.kernel.org
Cc:	akpm@...ux-foundation.org, salah.triki@...il.com,
	viro@...iv.linux.org.uk, mhocko@...e.com, vdavydov@...tuozzo.com,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: [PATCH 1/2] fs: befs: check silent flag before logging error

Log error only when silent flag is not set.

Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors")
Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
---

Hi,

Reading the backlog of latest patches to befs, I noticed that Salah's patch
missed one call to befs_error() when setting all to only be used when the
silent argument is false.

Thanks,
Luis

 fs/befs/linuxvfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index b700645..bf5658d 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -790,7 +790,8 @@ befs_fill_super(struct super_block *sb, void *data, int silent)
 	 */ 
 	blocksize = sb_min_blocksize(sb, 1024);
 	if (!blocksize) {
-		befs_error(sb, "unable to set blocksize");
+		if (!silent)
+			befs_error(sb, "unable to set blocksize");
 		goto unacquire_priv_sbp;
 	}
 
-- 
2.5.1