linux-kernel - Re: [PATCH] kthread: to_live_kthread() needs try_get_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jun 2016 16:01:19 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andy Lutomirski <luto@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Tejun Heo <tj@...nel.org>, LKP <lkp@...org>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel test robot <xiaolong.ye@...el.com>
Subject: Re: [PATCH] kthread: to_live_kthread() needs try_get_task_stack()

On Wed, Jun 29, 2016 at 11:03 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> On 06/29, Andy Lutomirski wrote:
>>
>> I pushed that change to my tree (seems to work well enough to boot
>> without warnings as long as I don't unmount XFS, but not particularly
>> well tested).  Want to refresh your patch on top?
>
> Please see the trivial fix below. Compile tested, but looks obvious.

I stuck it in my tree in the right place.  Thanks!

>
> Btw, why free_thread_stack() calls vfree() with irqs disabled? Doesn't
> look good and perhaps even wrong; at least vmap_debug_free_range() does
> flush_tlb_kernel_range() and smp_call_function() can deadlock?

Whoops, that's a bug.  Fixed now.

--Andy