linux-kernel - Re: [PATCH] drm: mediatek: fix prototypes after API change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871t3fb6h0.wl%kuninori.morimoto.gx@renesas.com>
Date:	Thu, 30 Jun 2016 05:24:47 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	David Airlie <airlied@...ux.ie>, Mark Brown <broonie@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Jie Qiu <jie.qiu@...iatek.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Junzhi Zhao <junzhi.zhao@...iatek.com>,
	<alsa-devel@...a-project.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>,
	"Stephen Rothwell" <sfr@...b.auug.org.au>
Subject: Re: [PATCH] drm: mediatek: fix prototypes after API change


Hi

> The newly added mediatek HDMI driver clashes with an API change
> for struct hdmi_codec_ops, causing an 'allmodconfig' build to fail:
> 
> drivers/gpu/drm/mediatek/mtk_hdmi.c:1653:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> drivers/gpu/drm/mediatek/mtk_hdmi.c:1654:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> drivers/gpu/drm/mediatek/mtk_hdmi.c:1655:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> drivers/gpu/drm/mediatek/mtk_hdmi.c:1656:18: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> drivers/gpu/drm/mediatek/mtk_hdmi.c:1657:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> This changes the API accordingly for the mediatek driver.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support")
> Fixes: efc9194bcff8 ("ASoC: hdmi-codec: callback function will be called with private data")
> ---
> The new driver is currently part of Dave Airlie's drm-next tree,
> while the API change is in Mark Brown's asoc-next tree, so my
> fix has to be done on top of both.
> 
> I can see two ways out of this:
> 
> a) Stephen Rothwell could add my fixup on top of linux-next
>    as a merge fix, and the fix gets sent to Linus Torvalds along
>    with the second of the two branches
> 
> b) efc9194bcff8 gets merged into drm-next along with my change
>    in the merge commit. It is currently a standalone patch
>    in its own branch in the ASoC tree.

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Best regards
---
Kuninori Morimoto