linux-kernel - RE: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C246CAC1457055469EF09E3A7AC4E11A4A5BA435@XAP-PVEXMBX01.xlnx.xilinx.com>
Date:	Thu, 30 Jun 2016 05:23:30 +0000
From:	Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	Michal Simek <michals@...inx.com>,
	Soren Brinkmann <sorenb@...inx.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"moritz.fischer@...us.com" <moritz.fischer@...us.com>,
	"laurent.pinchart@...asonboard.com" 
	<laurent.pinchart@...asonboard.com>,
	"luis@...ethencourt.com" <luis@...ethencourt.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	Punnaiah Choudary Kalluri <punnaia@...inx.com>
Subject: RE: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver
 support

Hi Vinod,

> 
> On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote:
> 
> > +	dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
> > +	dma_cap_set(DMA_SG, zdev->common.cap_mask);
> > +	dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask);
> 
> >  /**
> > + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure
> > + * @ovrfetch: Overfetch status
> > + * @has_sg: Support scatter gather transfers
> > + * @ratectrl: Rate control value
> > + * @src_issue: Out standing transactions on source
> > + * @src_burst_len: Source burst length
> > + * @dst_burst_len: Dest burst length
> > + */
> 
> As discussed in other thread as well, this is no-go for memcpy. Please come back
> after removing this
> 
> For slave usages use the dma_slave_config

Sure will fix in the next version...

Regards,
Kedar.

> 
> --
> ~Vinod