linux-kernel - Re: [PATCH 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <577473A3.9050808@hisilicon.com>
Date:	Thu, 30 Jun 2016 09:19:31 +0800
From:	liuxinliang <z.liuxinliang@...ilicon.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Kefeng Wang <wangkefeng.wang@...wei.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Jiri Slaby <jslaby@...e.com>, <linux-serial@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <guohanjun@...wei.com>
Subject: Re: [PATCH 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon
 Hip05 soc

Hi,

On 2016/6/29 20:52, Andy Shevchenko wrote:
> On Tue, 2016-06-28 at 11:17 +0800, Kefeng Wang wrote:
>> Make dw8250_set_termios() as the default set_termios callback for 8250
>> dw uart, correct me
>> if I am wrong.
>>
>> Then add ACPI support for uart on Hisilicon Hip05 soc, be careful that
>> it is not 16500
>> compatible.
> You mean it has Busy Functionality implemented?

Yes, I think so.

> Is there any public specification to look at?
Sorry, our SoC manual is not that public. But we confirm with SoC guys 
that 8250dw has 16550 compatible and non 16550 compatible version.
Ours is non 16550 compatible version. And we can see the IIR register 
has busy interrupt bit:
"0x7: busy interrupt. When UART is busy (USR[0]=1) in receiving
and transmitting data and the processor operates the LCR register,
this interrupt will be generated."

Thanks,
-xinliang

>
>>   Note, the build(no ACPI) depends on
>> https://patchwork.kernel.org/patch/9141207/,
>> which was already accepted in net-next.
>>
>> Meanwhile, set dw8250_serial_out32 to keep consistent between
>> serial_out
>> and serial_in in ACPI.
>>
>> Kefeng Wang (2):
>>    serial: 8250_dw: make dw8250_set_termios as default set_termios
>>      callback
>>    serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc
>>
>>   drivers/tty/serial/8250/8250_dw.c | 11 +++++++----
>>   1 file changed, 7 insertions(+), 4 deletions(-)
>>