linux-kernel - Re: [PATCH 04/15] lirc_dev: replace printk with pr_* or dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1467246446.24287.118.camel@perches.com>
Date:	Wed, 29 Jun 2016 17:27:26 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andi Shyti <andi.shyti@...sung.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH 04/15] lirc_dev: replace printk with pr_* or dev_*

On Wed, 2016-06-29 at 22:20 +0900, Andi Shyti wrote:
> This patch mutes also all the checkpatch warnings related to
> printk.
> 
> Reword all the printouts so that the string doesn't need to be
> split, which fixes the following checkpatch warning:

Adding

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any #include would allow these to be prefixed
automatically and allow the embedded prefixes to be removed.
> diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
[]
> @@ -240,59 +240,51 @@ static int lirc_allocate_driver(struct lirc_driver *d)
>  	int err;
>  
>  	if (!d) {
> -		printk(KERN_ERR "lirc_dev: lirc_register_driver: "
> -		       "driver pointer must be not NULL!\n");
> +		pr_err("lirc_dev: driver pointer must be not NULL!\n");
>  		err = -EBADRQC;
>  		goto out;
>  	}

		pr_err("driver pointer must not be NULL!\n");

And typical multiple line statement alignment is to
the open parenthesis.