linux-kernel - Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jun 2016 12:54:28 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, z.liuxinliang@...ilicon.com,
	guohanjun@...wei.com, linux-acpi@...r.kernel.org,
	xuwei5@...ilicon.com, graeme.gregory@...aro.org
Subject: Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on
 Hisilicon Hip05 soc

On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote:
> On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote:
> > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
> > that it is not 16550 compatibal.
> > 
> > Meanwhile, set dw8250_serial_out32 to keep consistent between
> > serial_out
> > and serial_in in ACPI.
> > 
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> > ---
> >  drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_dw.c
> > b/drivers/tty/serial/8250/8250_dw.c
> > index 65f3da7..096431b 100644
> > --- a/drivers/tty/serial/8250/8250_dw.c
> > +++ b/drivers/tty/serial/8250/8250_dw.c
> > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan
> > *chan, void *param)
> >  	return param == chan->device->dev->parent;
> >  }
> >  
> > +/* non 16550 compatible id list*/
> > +static const struct acpi_device_id non_16550_id_list[] = {
> > +	{ "HISI0031", 0 },
> > +	{ },
> > +};
> > +
> 
> On first glance it looks redundant, see below.

Oh, wait, this is still valid, but the better solution is to use device
properties for the rest except yours!

I will prepare patch later this week or at the beginning of next week if
you are in hurry, otherwise I would postpone this a bit (anyway it will
not make v4.8 cycle).

-- 

Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy