linux-kernel - Re: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160630.084454.396711639535557444.davem@davemloft.net>
Date:	Thu, 30 Jun 2016 08:44:54 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	decui@...rosoft.com
Cc:	gregkh@...uxfoundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, jasowang@...hat.com,
	vkuznets@...hat.com, cavery@...hat.com, kys@...rosoft.com,
	haiyangz@...rosoft.com, joe@...ches.com, rolf.neugebauer@...ker.com
Subject: Re: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Dexuan Cui <decui@...rosoft.com>
Date: Wed, 29 Jun 2016 11:30:40 +0000

> @@ -1509,4 +1509,18 @@ static inline void commit_rd_index(struct vmbus_channel *channel)
>  }
>  
>  
> +struct vmpipe_proto_header {
> +	u32 pkt_type;

It is wasteful to have two empty lines before this structure definition, one
is sufficient.

> +/*
> + * This is the address fromat of Hyper-V Sockets.
> + * Note: here we just borrow the kernel's built-in type uuid_le. When
> + * an application calls bind() or connect(), the 2 members of struct
> + * sockaddr_hv must be of GUID.
> + * The GUID format differs from the UUID format only in the byte order of
> + * the first 3 fields. Refer to:
> + * https://en.wikipedia.org/wiki/Globally_unique_identifier
> + */

Comments should be of the form:

	/* Like
	 * this.
	 */

Rather than:

	/*
	 * Like
	 * this.
	 */

> +	__le16		reserved;	     /* Must be Zero		*/

Why does an ignored, reserved, field need an endianness?  Just use
plain "u16" for this.

> +static
> +void hvsock_enqueue_accept(struct sock *listener, struct sock *connected)

Don't split the declaration after "static" with a newline, instead use:

====================
static void hvsock_enqueue_accept(struct sock *listener,
				  struct sock *connected)
====================

> +{
> +	struct hvsock_sock *hvlistener;
> +	struct hvsock_sock *hvconnected;

Please order local variables from logest to shortest line.

> +static struct sock *hvsock_dequeue_accept(struct sock *listener)
> +{
> +	struct hvsock_sock *hvlistener;
> +	struct hvsock_sock *hvconnected;

Likewise.

> +static void hvsock_sk_destruct(struct sock *sk)
> +{
> +	struct hvsock_sock *hvsk = sk_to_hvsock(sk);
> +	struct vmbus_channel *channel = hvsk->channel;

Likewise.

> +/* This function runs in the tasklet context of process_chn_event() */
> +static void hvsock_on_channel_cb(void *ctx)
> +{
> +	struct sock *sk = (struct sock *)ctx;
> +	struct hvsock_sock *hvsk = sk_to_hvsock(sk);
> +	struct vmbus_channel *channel = hvsk->channel;
> +	bool can_read, can_write;

Likewise.

> +static int hvsock_open_connection(struct vmbus_channel *channel)
> +{
> +	struct hvsock_sock *hvsk, *new_hvsk;
> +	struct sockaddr_hv hv_addr;
> +	struct sock *sk, *new_sk;
> +	unsigned char conn_from_host;

Likewise.

> +static int hvsock_connect_wait(struct socket *sock,
> +			       int flags, int current_ret)
> +{
> +	struct sock *sk = sock->sk;
> +	struct hvsock_sock *hvsk = sk_to_hvsock(sk);

Likewise.