linux-kernel - Re: [PATCH] jbd2: make journal y2038 safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160630154938.GG2028@thunk.org>
Date:	Thu, 30 Jun 2016 11:49:38 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	Arnd Bergmann <arnd@...db.de>, Jan Kara <jack@...e.com>,
	y2038@...ts.linaro.org, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jbd2: make journal y2038 safe

On Sun, Jun 19, 2016 at 05:53:47PM +0200, Jan Kara wrote:
> On Fri 17-06-16 17:39:00, Arnd Bergmann wrote:
> > The jbd2 journal stores the commit time in 64-bit seconds and 32-bit
> > nanoseconds, which avoids an overflow in 2038, but it gets the numbers
> > from current_kernel_time(), which uses 'long' seconds on 32-bit
> > architectures.
> > 
> > This simply changes the code to call current_kernel_time64() so
> > we use 64-bit seconds consistently.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted