linux-kernel - Re: [PATCH 1/2] lib: hexdump: use a look-up table to do hex_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467317186.24287.164.camel@perches.com>
Date:	Thu, 30 Jun 2016 13:06:26 -0700
From:	Joe Perches <joe@...ches.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Michal Nazarewicz <mina86@...a86.com>, zengzhaoxiu@....com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
	Borislav Petkov <bp@...e.de>, Michal Hocko <mhocko@...e.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Nicolas Iooss <nicolas.iooss_linux@....org>,
	"Steven Rostedt (Red Hat)" <rostedt@...dmis.org>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	Horacio Mijail Anton Quiles <hmijail@...il.com>
Subject: Re: [PATCH 1/2] lib: hexdump: use a look-up table to do hex_to_bin

On Thu, 2016-06-30 at 21:42 +0200, Geert Uytterhoeven wrote:
> Hi Joe,

Hi Geert.

> On Thu, Jun 30, 2016 at 9:26 PM, Joe Perches <joe@...ches.com> wrote:
[]
> > Perhaps _tolower should be used a bit more in lib
[]
> No, we do care about non-alphabetical characters here.
> Using _tolower is equivalent to ignoring bit 5 in each byte of the string.

Yeah, that can't work.
Rasmus V wrote the same thing to me offline.