linux-kernel - Re: [PATCH v3 5/7] PCI: Do not use IORESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c97584a0-b5b1-8660-1e16-04c43570eca6@linux.vnet.ibm.com>
Date:	Fri, 1 Jul 2016 15:04:10 +0800
From:	Yongji Xie <xyjxie@...ux.vnet.ibm.com>
To:	Gavin Shan <gwshan@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	bhelgaas@...gle.com, alex.williamson@...hat.com, aik@...abs.ru,
	benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
	corbet@....net, warrier@...ux.vnet.ibm.com,
	zhong@...ux.vnet.ibm.com, nikunj@...ux.vnet.ibm.com
Subject: Re: [PATCH v3 5/7] PCI: Do not use IORESOURCE_STARTALIGN to identify
 bridge resources

Hi Gavin,

On 2016/7/1 10:34, Gavin Shan wrote:

> On Thu, Jun 30, 2016 at 06:53:11PM +0800, Yongji Xie wrote:
>> Now we use the IORESOURCE_STARTALIGN to identify bridge resources
>> in __assign_resources_sorted(). That's quite fragile. We may also
>> set flag IORESOURCE_STARTALIGN for SR-IOV resources in some cases,
>> for example, using the option "noresize" of parameter
>> "pci=resource_alignment".
>>
>> In this patch, we try to use a more robust way to identify
>> bridge resources.
>>
>> Signed-off-by: Yongji Xie <xyjxie@...ux.vnet.ibm.com>
> Reviewed-by: Gavin Shan <gwshan@...ux.vnet.ibm.com>
>
> Yongji, I think this doesn't have to be part of this series, meaning
> it can be sent or merged separately.
>

Seems like I give a wrong example in my changelog.  The
parameter "pci=resource_alignment" would not set flag
IORESOURCE_STARTALIGN for SR-IOV resources as I replied
to you in previous patch. So this patch has nothing to do
with this series now, I will remove it as you suggested.

Thanks,
Yongji