linux-kernel - Re: [PATCH] sched: Assign !p->on_cpu to the second parameter of smp_cond_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160701065542.GJ30921@twins.programming.kicks-ass.net>
Date:	Fri, 1 Jul 2016 08:55:42 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	"T.Zhou" <t1zhou@....com>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Assign !p->on_cpu to the second parameter of
 smp_cond_load_acquire()

On Fri, Jul 01, 2016 at 11:08:01AM +0800, T.Zhou wrote:

> -	smp_cond_load_acquire(&p->on_cpu, !VAL);
> +	smp_cond_load_acquire(&p->on_cpu, !p->on_cpu);

Huh, what?! No, the second parameter should very much include VAL, which
gets assigned the value of *(&p->on_cpu).

Go read the macro, it even has a comment on.