linux-kernel - Re: [PATCH 3/4] spi: Add option to insert delay between transactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160701081636.GC6247@sirena.org.uk>
Date:	Fri, 1 Jul 2016 09:16:36 +0100
From:	Mark Brown <broonie@...nel.org>
To:	apronin@...omium.org
Cc:	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH 3/4] spi: Add option to insert delay between transactions

On Wed, Jun 29, 2016 at 08:54:26PM -0700, apronin@...omium.org wrote:

> Some devices may need CS to be deasserted for some time
> between transactions. Added a new capability to guarantee
> a delay between SPI transactions for the device.

This seems like even more of a per device thing - it's a very rare
requirement (I'm guessing for some SPI controller coprocessor) and
there's such a wide range of potential patterns that might be needed
by different devices.  

> +       if (msg->spi->xfer_delay)
> +               mdelay(msg->spi->xfer_delay);
> +
>         spi_set_cs(msg->spi, true);

This isn't a delay between messages, it's a delay before asserting
chip select which will happen every single time we do anything
regardless of if there was any activity immediately before or not.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)