linux-kernel - Re: [PATCH V6 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160701013847.GA25538@rob-hp-laptop>
Date:	Thu, 30 Jun 2016 20:38:47 -0500
From:	Rob Herring <robh@...nel.org>
To:	thloh@...era.com
Cc:	mark.rutland@....com, peppe.cavallaro@...com,
	alexandre.torgue@...com, davem@...emloft.net,
	preid@...ctromag.com.au, dinguyen@...nsource.altera.com,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, thloh85@...il.com, cnphoon@...era.com
Subject: Re: [PATCH V6 1/1] net: ethernet: Add TSE PCS support to
 dwmac-socfpga

On Wed, Jun 29, 2016 at 02:10:13AM -0700, thloh@...era.com wrote:
> From: Tien Hock Loh <thloh@...era.com>
> 
> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> the dwmac is set to sgmii.
> 
> Signed-off-by: Tien Hock Loh <thloh@...era.com>
> 
> ---
> v2:
> - Refactored the TSE PCS out from the dwmac-socfpga.c file
> - Added binding documentation for TSE PCS sgmii adapter
> v3:
> - Added missing license header for new source files
> - Updated tse_pcs.h include headers
> - Standardize if statements
> v4:
> - Reset SGMII adapter on speed change
> - Do not enable SGMII adapter if speed is not supported
> - On init, if PCS reset fails, do not enable adapter
> v5:
> - Fixed devicetree binding property name using _ instead of -
> v6:
> - Fixed a problem where driver build broken if driver is set as module
> ---
>  .../devicetree/bindings/net/socfpga-dwmac.txt      |  19 ++

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/net/ethernet/stmicro/stmmac/Makefile       |   3 +-
>  drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c | 276 +++++++++++++++++++++
>  drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.h |  36 +++
>  .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c    | 141 +++++++++--
>  5 files changed, 453 insertions(+), 22 deletions(-)
>  create mode 100644 drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
>  create mode 100644 drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.h