linux-kernel - Re: [PATCH] nbd: convert to blkmq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <57767D8E.40808@fb.com>
Date:	Fri, 1 Jul 2016 08:26:22 -0600
From:	Jens Axboe <axboe@...com>
To:	Josef Bacik <jbacik@...com>, <mpa@...gutronix.de>,
	<linux-kernel@...r.kernel.org>,
	<nbd-general@...ts.sourceforge.net>, <kernel-team@...com>,
	<linux-block@...r.kernel.org>
Subject: Re: [PATCH] nbd: convert to blkmq

On 07/01/2016 08:15 AM, Josef Bacik wrote:
> This moves NBD over to using blkmq, which allows us to get rid of the NBD
> wide queue lock and the async submit kthread.  We will start with 1 hw
> queue for now, but I plan to add multiple tcp connection support in the
> future and we'll fix how we set the hwqueue's.

Looks pretty clean. I'd get rid of that horrible nbd_find_request() as 
well, though. Store the request tag in the reply.handle, and then just 
lookup the request from the tag, if the tag is valid. The resulting 
request can then be checked for proper state (started).

nbd->active_cmd needs to die as well.

-- 
Jens Axboe