linux-kernel - Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Jul 2016 11:43:01 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	pi3orama <pi3orama@....com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
	linux-kernel@...r.kernel.org, Zefan Li <lizefan@...wei.com>
Subject: Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old
 kernel

Em Fri, Jul 01, 2016 at 10:27:35PM +0800, pi3orama escreveu:
> > 在 2016年7月1日，下午9:40，Arnaldo Carvalho de Melo <acme@...nel.org> 写道：
> > I.e. perhaps evsel->overwrite is completely unnecessary and places
> > checking for it should instead check for evsel->attr.backward, no?
 
> If we remove evsel->overwrite, what should we set in parser? Make it
> directly setting attr?

yeah, is that possible? Trying... And then overwrite is how we chose to
expose this to the user, in the event syntax, but internally that means
using the backwards_ring buffer, right?

So this simplifies the code, removing information that was being
duplicated in evsel->overwrite and evsel->attr.write_backward.

- Arnaldo