linux-kernel - Re: [PATCH] soc: qcom: smem: Silence probe defer error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160701214023.GM1190@tuxbot>
Date:	Fri, 1 Jul 2016 14:40:23 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Andy Gross <andy.gross@...aro.org>, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] soc: qcom: smem: Silence probe defer error

On Fri 01 Jul 14:18 PDT 2016, Stephen Boyd wrote:

> If we fail to get the hwspinlock due to probe defer, we shouldn't
> print an error message. Just be silent in this case.
> 

This generally seems to result in a large pile of drivers ending up on
the probe deferr list, so something we should try to avoid.

But the patch itself looks good:
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  drivers/soc/qcom/smem.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 2e1aa9f130f4..18ec52f2078a 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
>  
>  	hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
>  	if (hwlock_id < 0) {
> -		dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> +		if (hwlock_id != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "failed to retrieve hwlock\n");
>  		return hwlock_id;
>  	}
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>