linux-kernel - [PATCH] block: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Jul 2016 18:17:41 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Tahsin Erdogan <tahsin@...gle.com>
Cc:	kbuild-all@...org, Jens Axboe <axboe@...nel.dk>,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tahsin Erdogan <tahsin@...gle.com>
Subject: [PATCH] block: fix boolreturn.cocci warnings

block/elevator.c:73:9-10: WARNING: return of 0/1 in function 'elv_bio_merge_ok' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Tahsin Erdogan <tahsin@...gle.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 elevator.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/block/elevator.c
+++ b/block/elevator.c
@@ -70,12 +70,12 @@ static int elv_iosched_allow_bio_merge(s
 bool elv_bio_merge_ok(struct request *rq, struct bio *bio)
 {
 	if (!blk_rq_merge_ok(rq, bio))
-		return 0;
+		return false;
 
 	if (!elv_iosched_allow_bio_merge(rq, bio))
-		return 0;
+		return false;
 
-	return 1;
+	return true;
 }
 EXPORT_SYMBOL(elv_bio_merge_ok);