linux-kernel - Re: [PATCH 2/4] fs: befs: Coding style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5777A3D9.90808@osg.samsung.com>
Date:	Sat, 02 Jul 2016 12:22:01 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Salah Triki <salah.triki@...il.com>, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk
CC:	mhocko@...e.com, vdavydov@...tuozzo.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] fs: befs: Coding style fix

On 02/07/16 09:05, Salah Triki wrote:
> Constant has to be capitalized.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  fs/befs/btree.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> index 307645f9..e59ad20 100644
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -85,7 +85,7 @@ struct befs_btree_node {
>  };
>  
>  /* local constants */
> -static const befs_off_t befs_bt_inval = 0xffffffffffffffffULL;
> +static const befs_off_t BEFS_BT_INVAL = 0xffffffffffffffffULL;
>  
>  /* local functions */
>  static int befs_btree_seekleaf(struct super_block *sb, const befs_data_stream *ds,
> @@ -467,7 +467,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
>  	while (key_sum + this_node->head.all_key_count <= key_no) {
>  
>  		/* no more nodes to look in: key_no is too large */
> -		if (this_node->head.right == befs_bt_inval) {
> +		if (this_node->head.right == BEFS_BT_INVAL) {
>  			*keysize = 0;
>  			*value = 0;
>  			befs_debug(sb,
> @@ -608,7 +608,7 @@ static int
>  befs_leafnode(struct befs_btree_node *node)
>  {
>  	/* all interior nodes (and only interior nodes) have an overflow node */
> -	if (node->head.overflow == befs_bt_inval)
> +	if (node->head.overflow == BEFS_BT_INVAL)
>  		return 1;
>  	else
>  		return 0;
> 

Hi Salah,

What the coding style says is:
"Names of macros defining constants and labels in enums are capitalized."

Even though this isn't a macro, when reading the code it is good to know it is
almost like one. I agree this makes the code more readable.

Acked-by: Luis de Bethencourt <luisbg@....samsung.com>

Thanks,
Luis