| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 02 Jul 2016 09:34:49 +0800
From: Caesar Wang <wxt@...k-chips.com>
To: Doug Anderson <dianders@...omium.org>,
吴良峰 <william.wu@...k-chips.com>
CC: Caesar Wang <wxt@...k-chips.com>,
Tao Huang <huangtao@...k-chips.com>,
Heiko Stübner <heiko@...ech.de>,
Elaine Zhang <zhangqing@...k-chips.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
Eddie Cai <eddie.cai@...k-chips.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] arm64: dts: rockchip: add the power domain node for
rk3399
On 2016年07月02日 00:56, Doug Anderson wrote:
> Caesar
>
> On Thu, Jun 30, 2016 at 9:32 PM, Caesar Wang <wxt@...k-chips.com> wrote:
>> From: Elaine Zhang <zhangqing@...k-chips.com>
>>
>> In order to meet low power requirements, a power management unit (PMU) is
>> designed for controlling power resources in RK3399. The RK3399 PMU is
>> dedicated for managing the power of the whole chip.
>>
>> 1. add pd node for RK3399 Soc
>> 2. create power domain tree
>> 3. add qos node for domain
>>
>> From the DT/binds and driver can get more detail information:
>> The driver:
>> drivers/soc/rockchip/pm_domains.c
>> The document:
>> Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
>> ---
>>
>> Changes in v2:
>> - As Doug/Heiko commnets on https://patchwork.kernel.org/patch/9206415/.
>> drop the debugfs-dump and Add the comments for alphabetical order.
>>
>> Note: As the TRM lists many voltage domains and power domains, then
>> in actual we just need control some domains for driver.
>> Due to some domains (e.g. emmc, usb, core)...We can't turn off it on
>> bootup.
> I'm curious: why can't you turn off USB power domains if a board
> doesn't usb USB? ...or GMAC on boards that don't use Ethernet? ...or
> eDP on boards that don't use EDP?
>
> Maybe the driver for these things isn't ready to handle power domains
> yet so that's why they are left out for now?
>
> It seems like GMAC could at least be added because we don't even have
> the GMAC listed in the current device tree so therefore there can't be
> any users of it. When it's added we can make sure that the power
> domains are added.
At least, the gmac had been supported in rockchip inside.
That's seem the gmac driver can't handle the power domain enough.
--
Frankly, I'm no test the GMAC，then this patch should support most of
devices.
We can send another patch to support it if someone（usb/gmac) can handle
the power domain.
>
> I think in the current upstream dtsi file there is also no xhci node,
> so does that mean you could add the USB3 power domain?
>
>
willam@RK, what's think of it？
>> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
>> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-rockchip@...ts.infradead.org
>> Cc: Heiko Stuebner <heiko@...ech.de>
>>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 179 +++++++++++++++++++++++++++++++
>> 1 file changed, 179 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index a6dd623..103e185 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -45,6 +45,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/pinctrl/rockchip.h>
>> +#include <dt-bindings/power/rk3399-power.h>
>> #include <dt-bindings/thermal/thermal.h>
>>
>> / {
>> @@ -594,6 +595,184 @@
>> status = "disabled";
>> };
>>
>> + qos_hdcp: qos_hdcp@...90000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffa90000 0x0 0x20>;
>> + };
>> +
>> + qos_iep: qos_iep@...98000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffa98000 0x0 0x20>;
>> + };
>> +
>> + qos_isp0_m0: qos_isp0_m0@...a0000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffaa0000 0x0 0x20>;
>> + };
>> +
>> + qos_isp0_m1: qos_isp0_m1@...a0080 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffaa0080 0x0 0x20>;
>> + };
>> +
>> + qos_isp1_m0: qos_isp1_m0@...a8000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffaa8000 0x0 0x20>;
>> + };
>> +
>> + qos_isp1_m1: qos_isp1_m1@...a8080 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffaa8080 0x0 0x20>;
>> + };
>> +
>> + qos_rga_r: qos_rga_r@...b0000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffab0000 0x0 0x20>;
>> + };
>> +
>> + qos_rga_w: qos_rga_w@...b0080 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffab0080 0x0 0x20>;
>> + };
>> +
>> + qos_video_m0: qos_video_m0@...b8000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffab8000 0x0 0x20>;
>> + };
>> +
>> + qos_video_m1_r: qos_video_m1_r@...c0000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffac0000 0x0 0x20>;
>> + };
>> +
>> + qos_video_m1_w: qos_video_m1_w@...c0080 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffac0080 0x0 0x20>;
>> + };
>> +
>> + qos_vop_big_r: qos_vop_big_r@...c8000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffac8000 0x0 0x20>;
>> + };
>> +
>> + qos_vop_big_w: qos_vop_big_w@...c8080 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffac8080 0x0 0x20>;
>> + };
>> +
>> + qos_vop_little: qos_vop_little@...d0000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffad0000 0x0 0x20>;
>> + };
>> +
>> + qos_gpu: qos_gpu@...e0000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffae0000 0x0 0x20>;
>> + };
>> +
>> + pmu: power-management@...10000 {
>> + compatible = "rockchip,rk3399-pmu", "syscon", "simple-mfd";
>> + reg = <0x0 0xff310000 0x0 0x1000>;
>> +
>> + /*
>> + * Note: RK3399 supports 6 voltage domains including VD_CORE_L,
>> + * VD_CORE_B, VD_CENTER, VD_GPU, VD_LOGIC and VD_PMU.
>> + * Some of the power domains are grouped together for every
>> + * voltage domain.
>> + * The detail contents as below.
>> + */
>> + power: power-controller {
>> + status = "okay";
>> + compatible = "rockchip,rk3399-power-controller";
>> + #power-domain-cells = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + /* These power domains are grouped by VD_LOGIC */
>> + pd_vio@...399_PD_VIO {
>> + reg = <RK3399_PD_VIO>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + pd_isp0@...399_PD_ISP0 {
>> + reg = <RK3399_PD_ISP0>;
>> + clocks = <&cru ACLK_ISP0>,
>> + <&cru HCLK_ISP0>;
>> + pm_qos = <&qos_isp0_m0>,
>> + <&qos_isp0_m1>;
>> + };
>> + pd_isp1@...399_PD_ISP1 {
>> + reg = <RK3399_PD_ISP1>;
>> + clocks = <&cru ACLK_ISP1>,
>> + <&cru HCLK_ISP1>;
>> + pm_qos = <&qos_isp1_m0>,
>> + <&qos_isp1_m1>;
>> + };
>> + pd_vo@...399_PD_VO {
>> + reg = <RK3399_PD_VO>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + pd_vopb@...399_PD_VOPB {
>> + reg = <RK3399_PD_VOPB>;
>> + clocks = <&cru ACLK_VOP0>,
>> + <&cru HCLK_VOP0>;
>> + pm_qos = <&qos_vop_big_r>,
>> + <&qos_vop_big_w>;
>> + };
>> + pd_vopl@...399_PD_VOP {
>> + reg = <RK3399_PD_VOPL>;
>> + clocks = <&cru ACLK_VOP1>,
>> + <&cru HCLK_VOP1>;
>> + pm_qos = <&qos_vop_little>;
>> + };
>> + };
>> + pd_hdcp@...399_PD_HDCP {
>> + reg = <RK3399_PD_HDCP>;
>> + clocks = <&cru ACLK_HDCP>,
>> + <&cru HCLK_HDCP>,
>> + <&cru PCLK_HDCP>;
>> + pm_qos = <&qos_hdcp>;
>> + };
> HDCP sorts earlier than ISP0, so should be above that. Basically:
> anything in the same area should be sorted alphabetically.
The sort is follow up the TRM. At least I'm according to every voltage
domain.
>
>> + };
>> +
>> + /* These power domains are grouped by VD_CENTER */
>> + pd_vcodec@...399_PD_VCODEC {
>> + reg = <RK3399_PD_VCODEC>;
>> + clocks = <&cru ACLK_VCODEC>,
>> + <&cru HCLK_VCODEC>;
>> + pm_qos = <&qos_video_m0>;
>> + };
>> + pd_vdu@...399_PD_VDU {
>> + reg = <RK3399_PD_VDU>;
>> + clocks = <&cru ACLK_VDU>,
>> + <&cru HCLK_VDU>;
>> + pm_qos = <&qos_video_m1_r>,
>> + <&qos_video_m1_w>;
>> + };
>> + pd_rga@...399_PD_RGA {
>> + reg = <RK3399_PD_RGA>;
>> + clocks = <&cru ACLK_RGA>,
>> + <&cru HCLK_RGA>;
>> + pm_qos = <&qos_rga_r>,
>> + <&qos_rga_w>;
>> + };
>> + pd_iep@...399_PD_IE {
>> + reg = <RK3399_PD_IEP>;
>> + clocks = <&cru ACLK_IEP>,
>> + <&cru HCLK_IEP>;
>> + pm_qos = <&qos_iep>;
>> + };
> IE sorts before RGA. ...and both come before VCODEC / VDU.
Ditto
>
>> +
>> + /* These power domains are grouped by VD_GPU */
>> + pd_gpu@...399_PD_GPU {
>> + reg = <RK3399_PD_GPU>;
>> + clocks = <&cru ACLK_GPU>;
>> + pm_qos = <&qos_gpu>;
>> + };
>> + };
>> + };
>> +
>> pmugrf: syscon@...20000 {
>> compatible = "rockchip,rk3399-pmugrf", "syscon", "simple-mfd";
>> reg = <0x0 0xff320000 0x0 0x1000>;
>> --
>> 1.9.1
>>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
caesar wang | software engineer | wxt@...k-chip.com
Powered by blists - more mailing lists