linux-kernel - Re: [PATCH v3 1/2] iio: adc: max1363: Add device tree binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Jul 2016 08:56:05 +0200
From:	Florian Vaussard <florian.vaussard@...g-vd.ch>
To:	Jonathan Cameron <jic23@...nel.org>
CC:	Florian Vaussard <florian.vaussard@...il.com>,
	<devicetree@...r.kernel.org>, Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Martin Kepplinger <martink@...teo.de>,
	<linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Vaussard Florian <florian.vaussard@...g-vd.ch>
Subject: Re: [PATCH v3 1/2] iio: adc: max1363: Add device tree binding
 documentation

Hi Jonathan,

On 07/03/2016 12:41 PM, Jonathan Cameron wrote:
> On 30/06/16 08:43, Florian Vaussard wrote:
>> Add the device tree documentation for all the supported parts. Mandatory
>> binding is the compatible string and the slave I2C address.
>>
>> Optional properties can be used to specify the Vcc / Vref regulators, as
>> well as the IRQ line if available.
>>
>> Acked-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Florian Vaussard <florian.vaussard@...g-vd.ch>
> Really small point, but typically author sign off goes first then acks etc
> that are gained at any intermediate states, then the sign off of whoever takes
> the patch and applies it (here, that's me).  So it kind of communicates some
> idea of when in the process various tags were obtained.  It's not a rule
> set in stone though so I'll be lazy and leave this as it is.
> 

Agree, I will try to stick to this in the future. Looking at some previous
patches, I see that I used both styles without noticing.

> Anyhow, great and applied to the togreg branch of iio.git initially pushed
> out as testing for the autobuilders to poke it (or not in the case of this
> docume
> 

Great. Do you plan to send them for the next merge window, or will you wait for
the 4.9 cycle?

Best,
Florian