linux-kernel - Re: [PATCH] i2c: bcm2835: Set up the clock stretching timeout at boot.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lh1ip653.fsf@eliezer.anholt.net>
Date:	Sun, 03 Jul 2016 18:02:32 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: bcm2835: Set up the clock stretching timeout at boot.

Wolfram Sang <wsa@...-dreams.de> writes:

>> +	/*
>> +	 * SMBUS says "Devices participating in a transfer will
>> +	 * timeout when any clock low exceeds the value of
>> +	 * T_TIMEOUT,MIN of 25 ms."
>> +	 */
>
> SMBus has that timeout, but I2C doesn't. How about disabling the timeout
> simply? Or using the max value if you want to keep the timeout
> detection?

Disabling the timeout seems fine to me.  We still have a 1-second
timeout around the entire transfer.  I'll be back on my DSI branch this
week and test it out then.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)