linux-kernel - Re: [PATCH 0/2] KVM: MMU: support VMAs that got remap_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb14db6b-15c9-d277-6de7-f5cdcb10f977@redhat.com>
Date:	Mon, 4 Jul 2016 10:48:55 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>,
	Neo Jia <cjia@...dia.com>
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	Kirti Wankhede <kwankhede@...dia.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Radim Krčmář <rkrcmar@...hat.com>
Subject: Re: [PATCH 0/2] KVM: MMU: support VMAs that got remap_pfn_range-ed



On 04/07/2016 10:21, Xiao Guangrong wrote:
>>
>>     /*
>>      * In case the VMA has VM_MIXEDMAP set, whoever called
>> remap_pfn_range
>>      * is also going to call e.g. unmap_mapping_range before the
>> underlying
>>      * non-reserved pages are freed, which will then call our MMU
>> notifier.
>>      * We still have to get a reference here to the page, because the
>> callers
>>      * of *hva_to_pfn* and *gfn_to_pfn* ultimately end up doing a
>>      * kvm_release_pfn_clean on the returned pfn.  If the pfn is
>>      * reserved, the kvm_get_pfn/kvm_release_pfn_clean pair will simply
>>      * do nothing.
>>      */
>>
> 
> Excellent. I like it. :)

So is it Reviewed-by Guangrong? :)

Paolo