linux-kernel - Re: [PATCH v2 7/8] mm/zsmalloc: add __init,_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADAEsF91-j-DDXt63-dtG77Q5uowb8hdvT2Zk54B74XwDxFCxQ@mail.gmail.com>
Date:	Mon, 4 Jul 2016 17:21:43 +0800
From:	Ganesh Mahendran <opensource.ganesh@...il.com>
To:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Linux-MM <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan@...nel.org>,
	Nitin Gupta <ngupta@...are.org>, rostedt@...dmis.org,
	mingo@...hat.com
Subject: Re: [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute

Hi, Sergey

2016-07-04 16:43 GMT+08:00 Sergey Senozhatsky
<sergey.senozhatsky.work@...il.com>:
> On (07/04/16 14:49), Ganesh Mahendran wrote:
> [..]
>> -static void zs_unregister_cpu_notifier(void)
>> +static void __exit zs_unregister_cpu_notifier(void)
>>  {
>
> this __exit symbol is called from `__init zs_init()' and thus is
> free to crash.

I change code to force the code goto notifier_fail where the
zs_unregister_cpu_notifier will be called.
I tested with zsmalloc module buildin and built as a module.

Please correct me, if I miss something.

Thanks.


>
>         -ss