linux-kernel - Re: [PATCH v2 10/15] [media] lirc_dev: remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Jul 2016 13:39:25 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Andi Shyti <andi.shyti@...sung.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	Joe Perches <joe@...ches.com>, Sean Young <sean@...s.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT
 precompiler check

On 07/01/2016 10:01 AM, Andi Shyti wrote:
> There is no need to check in precompilation whether the ioctl is
> compat or unlocked, depending on the configuration it will be
> called the correct one.
> 
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> ---
>  drivers/media/rc/lirc_dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
> index d98a9f1..16cca46 100644
> --- a/drivers/media/rc/lirc_dev.c
> +++ b/drivers/media/rc/lirc_dev.c
> @@ -150,9 +150,7 @@ static const struct file_operations lirc_dev_fops = {
>  	.write		= lirc_dev_fop_write,
>  	.poll		= lirc_dev_fop_poll,
>  	.unlocked_ioctl	= lirc_dev_fop_ioctl,
> -#ifdef CONFIG_COMPAT
>  	.compat_ioctl	= lirc_dev_fop_ioctl,
> -#endif

I'd say this compat_ioctl can be dropped completely since there is nothing to do.

Regards,

	Hans

>  	.open		= lirc_dev_fop_open,
>  	.release	= lirc_dev_fop_close,
>  	.llseek		= noop_llseek,
>