lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Jul 2016 10:18:52 +1000 From: Julian Calaby <julian.calaby@...il.com> To: Javier Martinez Canillas <javier@....samsung.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Amitkumar Karwar <akarwar@...vell.com>, Kalle Valo <kvalo@...eaurora.org>, netdev <netdev@...r.kernel.org>, linux-wireless <linux-wireless@...r.kernel.org>, Nishant Sarmukadam <nishants@...vell.com> Subject: Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback Hi All, On Sat, Jul 2, 2016 at 5:39 AM, Javier Martinez Canillas <javier@....samsung.com> wrote: > The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") attempted to fix an issue when a new AP interface is added. > > But the patch didn't check the return value of the functions doing the > firmware calls and returned an error even if the functions didn't fail. > > This prevents the network device to be registered properly, so fix it. > > Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") > Signed-off-by: Javier Martinez Canillas <javier@....samsung.com> Looks correct to me as Dan Carpenter submitted the same fix. Reviewed-by: Julian Calaby <julian.calaby@...il.com> Thanks, -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists