linux-kernel - Re: [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hshvopp3c.wl-tiwai@suse.de>
Date:	Tue, 05 Jul 2016 08:37:43 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Arnd Bergmann" <arnd@...db.de>
Cc:	"Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning

On Mon, 04 Jul 2016 17:07:45 +0200,
Arnd Bergmann wrote:
> 
> The awacs sound driver produces a false-positive warning in ppc64_defconfig:
> 
> sound/ppc/awacs.c: In function 'snd_pmac_awacs_init':
> include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> I haven't come up with a good way to rewrite the code to avoid the
> warning, so here is a bad one: I initialize the variable before
> the conditionall initialization so gcc no longer has to worry about
> it.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.


Takashi