linux-kernel - [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1467712733-15800-1-git-send-email-alim.akhtar@samsung.com>
Date:	Tue, 05 Jul 2016 15:28:52 +0530
From:	Alim Akhtar <alim.akhtar@...sung.com>
To:	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Cc:	alexandre.belloni@...e-electrons.com, k.kozlowski@...sung.com,
	javier@....samsung.com, pankaj.dubey@...sung.com,
	alim.akhtar@...sung.com
Subject: [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable already
 disabled clock

At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc
clock already disabled (by s3c_rtc_gettime()), which looks extra and
unnecessary call. Lets clean it up.

Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Reviewed-by: Pankaj Dubey <pankaj.dubey@...sung.com>
Tested-by: Pankaj Dubey <pankaj.dubey@...sung.com>
---
 drivers/rtc/rtc-s3c.c |    2 --
 1 file changed, 2 deletions(-)

* Changes from v1
   -updated commit message as suggested by Krzysztof.
   -updated reviewed-by, tested-by tags

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index d01ad7e..b083840 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -577,8 +577,6 @@ static int s3c_rtc_probe(struct platform_device *pdev)
 
 	s3c_rtc_setfreq(info, 1);
 
-	s3c_rtc_disable_clk(info);
-
 	return 0;
 
  err_nortc:
-- 
1.7.10.4