linux-kernel - Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <577B85F1.9010004@linaro.org>
Date:	Tue, 5 Jul 2016 12:03:29 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Wan Zongshun <vw@...mu.org>, linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@...linux.org.uk>,
	devicetree@...r.kernel.org
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Wan Zongshun <mcuos.com@...il.com>,
	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

On 07/05/2016 10:21 AM, Wan Zongshun wrote:

[ ... ]

>>> +    setup_irq(irq, &nuc970_timer0_irq);
>>
>> s/setup_irq/request_irq/
> 
> Do you think I should use request_irq instead of setup_irq?

Yes.


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog