| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jul 2016 12:17:51 +0200 From: Philipp Zabel <p.zabel@...gutronix.de> To: linux-kernel@...r.kernel.org Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, Steffen Trumtrar <s.trumtrar@...gutronix.de>, Dinh Nguyen <dinguyen@...nsource.altera.com>, linux-arm-kernel@...ts.infradead.org, Philipp Zabel <p.zabel@...gutronix.de> Subject: [PATCH 2/3] reset: sunxi: use readl/writel_relaxed This just removes the rmb()/wmb() pair between register read and write. Since no relevant reads follow the rmb and no relevant writes precede the wmb, they should be safe to remove. Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de> --- drivers/reset/reset-sunxi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c index 3080190..7a35950 100644 --- a/drivers/reset/reset-sunxi.c +++ b/drivers/reset/reset-sunxi.c @@ -41,8 +41,8 @@ static int sunxi_reset_assert(struct reset_controller_dev *rcdev, spin_lock_irqsave(&data->lock, flags); - reg = readl(data->membase + (bank * 4)); - writel(reg & ~BIT(offset), data->membase + (bank * 4)); + reg = readl_relaxed(data->membase + (bank * 4)); + writel_relaxed(reg & ~BIT(offset), data->membase + (bank * 4)); spin_unlock_irqrestore(&data->lock, flags); @@ -62,8 +62,8 @@ static int sunxi_reset_deassert(struct reset_controller_dev *rcdev, spin_lock_irqsave(&data->lock, flags); - reg = readl(data->membase + (bank * 4)); - writel(reg | BIT(offset), data->membase + (bank * 4)); + reg = readl_relaxed(data->membase + (bank * 4)); + writel_relaxed(reg | BIT(offset), data->membase + (bank * 4)); spin_unlock_irqrestore(&data->lock, flags); -- 2.8.1
Powered by blists - more mailing lists