linux-kernel - Re: [PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f68379db-872b-7f74-ee22-c1365f2cf914@itdev.co.uk>
Date:	Tue, 5 Jul 2016 11:19:23 +0100
From:	Nick Dyer <nick.dyer@...ev.co.uk>
To:	Andrew Duggan <aduggan@...aptics.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Vincent Huang <vincent.huang@...synaptics.com>
Subject: Re: [PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to
 rmi_function in f12_data

On 25/06/2016 01:19, Andrew Duggan wrote:
> The pointer to struct rmi_function in f12_data is never set and was never
> used. The fn pointer is also stored in rmi_2d_sensor which is a member of
> f12_data.
> 
> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>

Reviewed-by: Nick Dyer <nick@...anahar.org>

> ---
>  drivers/input/rmi4/rmi_f12.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 041a91d..7d66766 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -27,7 +27,6 @@ enum rmi_f12_object_type {
>  };
>  
>  struct f12_data {
> -	struct rmi_function *fn;
>  	struct rmi_2d_sensor sensor;
>  	struct rmi_2d_sensor_platform_data sensor_pdata;
>  	bool has_dribble;
>