linux-kernel - Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160705105526.GK11498@techsingularity.net>
Date:	Tue, 5 Jul 2016 11:55:26 +0100
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
Cc:	Michal Hocko <mhocko@...nel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting
 by approximating retries

On Tue, Jul 05, 2016 at 04:07:23PM +0800, Hillf Danton wrote:
> > +		/*
> > +		 * Would the allocation succeed if we reclaimed the whole
> > +		 * available? This is approximate because there is no
> > +		 * accurate count of reclaimable pages per zone.
> > +		 */
> > +		for (zid = 0; zid <= zone_idx(zone); zid++) {
> > +			struct zone *check_zone = &current_pgdat->node_zones[zid];
> > +			unsigned long estimate;
> > +
> > +			estimate = min(check_zone->managed_pages, available);
> > +			if (__zone_watermark_ok(check_zone, order,
> > +					min_wmark_pages(check_zone), ac_classzone_idx(ac),
> > +					alloc_flags, available)) {
> > +			}
> Stray indent?
> 

Last minute rebase-related damage. I'll fix it.

-- 
Mel Gorman
SUSE Labs