linux-kernel - Re: [PATCH] sched/core: really pretend early bootup to be a normal task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160705124129.GB30921@twins.programming.kicks-ass.net>
Date:	Tue, 5 Jul 2016 14:41:29 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Sasha Levin <sasha.levin@...cle.com>,
	Yao Dongdong <yaodongdong@...wei.com>
Subject: Re: [PATCH] sched/core: really pretend early bootup to be a normal
 task

On Tue, Jul 05, 2016 at 02:23:23PM +0300, Konstantin Khlebnikov wrote:
> Commit 1b537c7d1e58 ("sched/core: Remove check of p->sched_class") placed
> "current->sched_class = &fair_sched_class" before call of init_idle() which
> immediately set sched_class back to idle_sched_class.
> 
> This patch reverts this piece because after commit de9b8f5dcbd9 ("sched:
> Fix crash trying to dequeue/enqueue the idle thread") init_idle() doesn't
> call do_set_cpus_allowed() and nobody will dereference ->sched_class.

I don't understand, what is broken?