linux-kernel - Re: [PATCH] arm64: dts: Fix rtc by providing rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caea8f78-be5e-233f-c475-41c2973761ae@osg.samsung.com>
Date:	Tue, 5 Jul 2016 09:03:02 -0400
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Alim Akhtar <alim.akhtar@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Cc:	devicetree@...r.kernel.org, catalin.marinas@....com,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	k.kozlowski@...sung.com, pankaj.dubey@...sung.com
Subject: Re: [PATCH] arm64: dts: Fix rtc by providing rtc_src clock

Hello Alim,

On 07/05/2016 06:05 AM, Alim Akhtar wrote:
> Add rtc source clock as exynos7 needs source (32.768KHz) clock
> for rtc block. Without this currently rtc driver probe is broken
> on this SoC, thats because rtc-s3c driver expect rtc_src clock to
> be provided for _s3c6410-rtc_ type rtc controllers.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index 03f9cf6..7f48cf0 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -12,6 +12,7 @@
>  /dts-v1/;
>  #include "exynos7.dtsi"
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/clock/samsung,s2mps11.h>
>  
>  / {
>  	model = "Samsung Exynos7 Espresso board based on EXYNOS7";
> @@ -44,6 +45,8 @@
>  
>  &rtc {
>  	status = "okay";
> +	clocks = <&clock_ccore PCLK_RTC>, <&s2mps15_osc S2MPS11_CLK_AP>;
> +	clock-names = "rtc", "rtc_src";
>  };
>  
>  &watchdog {
> 

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America