linux-kernel - pn533 driver crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <577BBC9C.4030107@dev.rtsoft.ru>
Date:	Tue, 5 Jul 2016 16:56:44 +0300
From:	Nikita Yushchenko <nyushchenko@....rtsoft.ru>
To:	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	Waldemar Rymarkiewicz <waldemar.rymarkiewicz@...to.com>,
	Michael Thalmeier <michael.thalmeier@...e.at>,
	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	arusalin <arusalin@....rtsoft.ru>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: pn533 driver crash

Hi

We have ported pn533 driver from current upstream kernel to vendor
kernel that our target hardware runs, and are having crashes.

Analysis shows that same is possible in upstream kernel as well.

commit b31d5103c message states that pn533_recv_frame() can be entered
with dev->cmd not set.  And in this case, change done by that commit
jumps directly to queue_work().

However, work routine pn533_wq_cmd_complete() unconditionally calls
pn533_send_async_complete(), and that unconditionally dereferences
dev->cmd. Thus crash.

Not yet sure how to fix that properly...

WBR,
Nikita Yushchenko