linux-kernel - Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3303be0f-af5a-282a-e7d6-bf16a4aee2e1@cogentembedded.com>
Date:	Tue, 5 Jul 2016 20:55:09 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	David Howells <dhowells@...hat.com>, davem@...emloft.net
Cc:	netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 01/24] rxrpc: Fix processing of
 authenticated/encrypted jumbo packets

Hello.

On 07/05/2016 04:12 PM, David Howells wrote:

> When a jumbo packet is being split up and processed, the crypto checksum
> for each split-out packet is in the jumbo header and needs placing in the
> reconstructed packet header.
>
> When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the

    scripts/checkpatch.pl now enforces the common commit citing style as for 
the Fixes: tag and the patch description, you need to specify the summary too.

> stored copy of the packet header in host byte order, this reconstruction
> was missed.
>
> Found with sparse with CF=-D__CHECK_ENDIAN__:
>
>     ../net/rxrpc/input.c:479:33: warning: incorrect type in assignment (different base types)
>     ../net/rxrpc/input.c:479:33:    expected unsigned short [unsigned] [usertype] _rsvd
>     ../net/rxrpc/input.c:479:33:    got restricted __be16 [addressable] [usertype] _rsvd
>
> Signed-off-by: David Howells <dhowells@...hat.com>
[...]

MBR, Sergei