linux-kernel - Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160705145732.4b6dbd55@gandalf.local.home>
Date:	Tue, 5 Jul 2016 14:57:32 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Franck Bui <fbui@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages
 on release

On Tue, 5 Jul 2016 20:45:17 +0200
Borislav Petkov <bp@...en8.de> wrote:

> On Tue, Jul 05, 2016 at 02:26:48PM -0400, Steven Rostedt wrote:
> > > +	if (rs->missed)
> > > +		printk(KERN_WARNING "%s: %d output lines suppressed due to ratelimiting\n",
> > > +		       current->comm, rs->missed);  
> > 
> > Is the comm important?  
> 
> Yes, we wanna dump the task name which called devkmsg_release().
> 
> > Maybe add the function that called it?
> > 
> >     "%pS", _THIS_IP_
> > 
> > Perhaps add __always_inline, as _THIS_IP_ will point into the function
> > that calls this?  
> 
> That would inadvertently be devkmsg_release() in this use case. But
> we want to dump the task name which opened and spat so much crap into
> /dev/kmsg so as to cause the ratelimiting to hit.
> 

Perhaps we should show both, unless you don't think this will ever be
used by anything other than devkmsg?

-- Steve