linux-kernel - Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73916037-eaba-a3b2-9445-b3fb572e97c8@kernel.org>
Date:	Tue, 5 Jul 2016 21:04:56 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Martin Kepplinger <martink@...teo.de>,
	Bijosh Thykkoottathil <bijosh.t@...mail.com>,
	"knaack.h@....de" <knaack.h@....de>,
	"lars@...afoo.de" <lars@...afoo.de>,
	"pmeerw@...erw.net" <pmeerw@...erw.net>,
	"christoph.muellner@...obroma-systems.com" 
	<christoph.muellner@...obroma-systems.com>
Cc:	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return
 statements

On 04/07/16 13:23, Martin Kepplinger wrote:
> Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil:
>> Removed unwanted return statements from the function
>> mma8452_set_freefall_mode.
> 
> You could've said "Don't unnecessarily save a return value.", but
> whatever :) Thanks for your review!
> 
>>
>> Signed-off-by: Bijosh Thykkoottathil <bijosh.t@...mail.com>
> Reviewed-by: Martin Kepplinger <martink@...teo.de>
Hi Martin,

I've flipped that tag over to an Acked-by which is more
appropriate in this case as an in depth review as signalled
by Reviewed-by would be 'interesting' here ;)

I'm enjoying the slightly doom laden commit messages :)

Applied.

Jonathan
> 
>> ---
>>  drivers/iio/accel/mma8452.c | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>> index e225d3c..d4a6d44 100644
>> --- a/drivers/iio/accel/mma8452.c
>> +++ b/drivers/iio/accel/mma8452.c
>> @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state)
>>  		val |= MMA8452_FF_MT_CFG_OAE;
>>  	}
>>  
>> -	val = mma8452_change_config(data, chip->ev_cfg, val);
>> -	if (val)
>> -		return val;
>> -
>> -	return 0;
>> +	return mma8452_change_config(data, chip->ev_cfg, val);
>>  }
>>  
>>  static int mma8452_set_hp_filter_frequency(struct mma8452_data *data,
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>