linux-kernel - Re: [PATCH v2] netfilter: nf_log: fix error on write NONE to logger choice sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160706092156.GA950@salvia>
Date:	Wed, 6 Jul 2016 11:22:10 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Pavel Tikhomirov <ptikhomirov@...tuozzo.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Eric Leblond <eric@....fr>, Patrick McHardy <kaber@...sh.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pavel Emelyanov <xemul@...tuozzo.com>,
	Konstantin Khorenko <khorenko@...tuozzo.com>, devel@...nvz.org
Subject: Re: [PATCH v2] netfilter: nf_log: fix error on write NONE to logger
 choice sysctl

On Fri, Jul 01, 2016 at 04:53:54PM +0300, Pavel Tikhomirov wrote:
> It is hard to unbind nf-logger:
> 
>   echo NONE > /proc/sys/net/netfilter/nf_log/0
>   bash: echo: write error: No such file or directory
> 
>   sysctl -w net.netfilter.nf_log.0=NONE
>   sysctl: setting key "net.netfilter.nf_log.0": No such file or directory
>   net.netfilter.nf_log.0 = NONE
> 
> You need explicitly send '\0', for instance like:
> 
>   echo -e "NONE\0" > /proc/sys/net/netfilter/nf_log/0
> 
> That seem to be strange, so fix it using proc_dostring.
> 
> Now it works fine:
>    modprobe nfnetlink_log
>    echo nfnetlink_log > /proc/sys/net/netfilter/nf_log/0
>    cat /proc/sys/net/netfilter/nf_log/0
>    nfnetlink_log
>    echo NONE > /proc/sys/net/netfilter/nf_log/0
>    cat /proc/sys/net/netfilter/nf_log/0
>    NONE

Applied, thanks.