lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Jul 2016 13:07:15 +0300 From: Mika Westerberg <mika.westerberg@...ux.intel.com> To: Linus Walleij <linus.walleij@...aro.org> Cc: Bin Gao <bin.gao@...ux.intel.com>, Mathias Nyman <mathias.nyman@...ux.intel.com>, Alexandre Courbot <gnurou@...il.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, Andy Shevchenko <andy.shevchenko@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>, Yegnesh S Iyer <yegnesh.s.iyer@...el.com>, Bin Gao <bin.gao@...el.com> Subject: Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver On Wed, Jul 06, 2016 at 10:57:19AM +0200, Linus Walleij wrote: > On Tue, Jun 28, 2016 at 1:56 AM, Bin Gao <bin.gao@...ux.intel.com> wrote: > > > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > > This driver is based on gpio-crystalcove.c. > > > > Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com> > > Signed-off-by: Bin Gao <bin.gao@...el.com> > > --- > > Changes in v4: > > - Converted CTLI_INTCNT_XX macros to less verbose ones INT_DETECT_XX. > > - Add comments about why there is no .pm for the driver. > > - Header files re-ordered. > > - Various coding style change to address Andy's comments. > > Mika can I have your ACK/review tag on this driver so I can merge it? > I prefer to have all Intel stuff bearing your seal of approval. Thanks for your trust :) I don't have much comments in addition to what you already pointed out. I'll just wait for the next revision and give my ack then. > > +static irqreturn_t wcove_gpio_irq_handler(int irq, void *data) > > +{ > > + int pending; > > + unsigned int p0, p1, virq, gpio; > > + struct wcove_gpio *wg = data; Bin, Since you are going to make another iteration, please arrange the declarations like: unsigned int p0, p1, virq, gpio; struct wcove_gpio *wg = data; int pending;
Powered by blists - more mailing lists