linux-kernel - Re: [PATCH 26/27] [AARCH64] Change type of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 06 Jul 2016 12:36:40 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	"Zhangjian \(Bamvor\)" <bamvor.zhangjian@...wei.com>
Cc:	Yury Norov <ynorov@...iumnetworks.com>,
	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<joseph@...esourcery.com>, <pinskia@...il.com>,
	Andrew Pinski <apinski@...ium.com>
Subject: Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

"Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com> writes:

> Hi, Yury
>
> On 2016/6/21 13:07, Yury Norov wrote:
>> From: Andrew Pinski <apinski@...ium.com>
>>
>> So that ILP32 is aligned to 64bits.
>>
>> Signed-off-by: Yury Norov <ynorov@...iumnetworks.com>
>> ---
>>   sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h b/sysdeps/aarch64/nptl/bits/semaphore.h
>> index 3cc5b37..3fe6047 100644
>> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
>> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
>> @@ -31,5 +31,5 @@
>>   typedef union
>>   {
>>     char __size[__SIZEOF_SEM_T];
>> -  long int __align;
>> +  long long int __align;
> Why we need align to 64bit?

Because aarch64 defines __HAVE_64B_ATOMICS.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@...e.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."