linux-kernel - Re: [PATCH v6 6/8] efi: load SSTDs from EFI variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 12:58:27 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Octavian Purdila <octavian.purdila@...el.com>
Cc:	"Rafael J . Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, Mark Brown <broonie@...nel.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Joel Becker <jlbec@...lplan.org>, linux-acpi@...r.kernel.org,
	linux-efi@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	irina.tirdea@...el.com, leonard.crestez@...el.com,
	geert@...ux-m68k.org
Subject: Re: [PATCH v6 6/8] efi: load SSTDs from EFI variables

On Tue, 05 Jul, at 01:09:52PM, Octavian Purdila wrote:
> This patch allows SSDTs to be loaded from EFI variables. It works by
> specifying the EFI variable name containing the SSDT to be loaded. All
> variables with the same name (regardless of the vendor GUID) will be
> loaded.
> 
> Note that we can't use acpi_install_table and we must rely on the
> dynamic ACPI table loading and bus re-scanning mechanisms. That is
> because I2C/SPI controllers are initialized earlier then the EFI
> subsystems and all I2C/SPI ACPI devices are enumerated when the
> I2C/SPI controllers are initialized.
> 
> Signed-off-by: Octavian Purdila <octavian.purdila@...el.com>
> ---
> 
> As the rest of the series remains unchanged and it got Acks from most
> of the other patches, I've resend only this patch. Rafael, please let
> me know if you prefer to resend the whole series.
> 
> Changes from v5:
> 
> * enable duplicate detection to avoid firmware bugs that returns the
> same variable over and over again; this requires pushing the entry
> allocation back into efivar_ssdt_iter() and creating a temporary list
> that is iterated over in efivar_ssdt_load()
> 
> * marked efivar_ssdt with __initdata
> 
> 
>  Documentation/acpi/ssdt-overlays.txt | 67 +++++++++++++++++++++++++
>  Documentation/kernel-parameters.txt  |  7 +++
>  drivers/firmware/efi/efi.c           | 96 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 170 insertions(+)

Looks fine to me. Thanks Octavian.

Reviewed-by: Matt Fleming <matt@...eblueprint.co.uk>