linux-kernel - Re: [PATCH RESENT] dm: Check kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160706133129.GB28379@redhat.com>
Date:	Wed, 6 Jul 2016 09:31:29 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	Minfei Huang <mnghuan@...il.com>
Cc:	agk@...hat.com, shli@...nel.org, dm-devel@...hat.com,
	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESENT] dm: Check kthread_run's return value

On Wed, Jul 06 2016 at  9:27am -0400,
Minfei Huang <mnghuan@...il.com> wrote:

> On 07/06/16 at 09:16P, Mike Snitzer wrote:
> > On Mon, Jul 04 2016 at 11:25am -0400,
> > Minfei Huang <mnghuan@...il.com> wrote:
> > 
> > > kthread function is used to process kthread_work. And there is no return
> > > value checking during create this thread. Add this checking to fix this
> > > issue.
> > > 
> > > Signed-off-by: Minfei Huang <mnghuan@...il.com>
> > This needed rebasing against linux-dm.git's 'for-next'.  I've now staged
> > this fix for 4.8 inclusion, see:
> > https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=7193a9defcab6f3d3f1eb64c68bad7534e5a39ad
> 
> Seems that we should fix it in stable as well.

Given the code movement it isn't easy to do (by simply adding a stable@
cc).  I've not seen a single report of an ignored kthread_run() failure
for multipath using .request_fn interface.