linux-kernel - Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160706133444.GD3623@piout.net>
Date:	Wed, 6 Jul 2016 15:34:44 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Wei Yongjun <weiyj_lk@....com>
Cc:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to
 simplify the code

On 06/07/2016 at 21:19:34 +0800, Wei Yongjun wrote :
> Hi,
> 
> On 07/06/2016 08:18 PM, Alexandre Belloni wrote:
> > Hi,
> >
> > On 06/07/2016 at 12:08:05 +0000, weiyj_lk@....com wrote :
> >> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> >>
> >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
> >>
> > I'm guessing you found that using coccinnelle or any other static
> > analysis tool. Can you mention that in the commit message?
> >
> Your are right, this patch is found by coccinelle and created by scripts.
> (I called it dpatch, a kernel patch IDE, which had integrated coccinelle,
> sparse engine, scripts to found and create kernel patch.
> REF: https://github.com/weiyj/dpatch-devel).
> 
> I mentioned those in passed, but no all of people like this.
> 

Well it helps knowing whether this has been tested on actual hardware or
not.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com