linux-kernel - Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <577C4CE2.2090103@samsung.com>
Date:	Wed, 06 Jul 2016 09:12:18 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Seung-Woo Kim <sw0312.kim@...sung.com>,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	k.kozlowski@...sung.com, kgene@...nel.org
Subject: Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers

On 2016년 07월 05일 20:40, Seung-Woo Kim wrote:
> This patch fixes wrong count of array for srom registers from probe
> function.
> 
> Signed-off-by: Seung-Woo Kim <sw0312.kim@...sung.com>
> ---
>  drivers/memory/samsung/exynos-srom.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
> index 96756fb..c66d2bd 100644
> --- a/drivers/memory/samsung/exynos-srom.c
> +++ b/drivers/memory/samsung/exynos-srom.c
> @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, srom);
>  
>  	srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,
> -			sizeof(exynos_srom_offsets));
> +			ARRAY_SIZE(exynos_srom_offsets));
>  	if (!srom->reg_offset) {
>  		iounmap(srom->reg_base);
>  		return -ENOMEM;
> 

On the exynos-srom.c, use the ARRAY_SIZE to get the number of array entry.
Looks good to me.

Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Thanks,
Chanwoo Choi