linux-kernel - RE: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 06 Jul 2016 02:47:45 +0000
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Peter Chen <peter.chen@....com>,
	linux-renesas-soc@...r.kernel.org 
	<linux-renesas-soc@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-kernel@...r.kernel.org 
	<linux-kernel@...r.kernel.org>,
	linux-pm@...r.kernel.org 
	<linux-pm@...r.kernel.org>,
	linux-samsung-soc@...r.kernel.org 
	<linux-samsung-soc@...r.kernel.org>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Subject: RE: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle

> 
> --------- Original Message ---------
> Sender : Peter Chen <peter.chen@....com>
> Date   : 2016-07-01 18:49 (GMT+9)
> Title  : [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle
>  
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>  
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Signed-off-by: Peter Chen <peter.chen@....com>

With the change (build error fix) of the following added, (I'll update)
Signed-off-by: MyungJoo Ham <myungjoo.ham@...sung.com>


Cheers,
MyungJoo

> ---
>  drivers/devfreq/exynos-bus.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>  
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 2363d0a..a38b5ec 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -383,7 +383,7 @@ err_clk:
>  static int exynos_bus_probe(struct platform_device *pdev)
>  {
>          struct device *dev = &pdev->dev;
> -        struct device_node *np = dev->of_node;
> +        struct device_node *np = dev->of_node, node;

+	struct device_node *np = dev->of_node, *node;

>          struct devfreq_dev_profile *profile;
>          struct devfreq_simple_ondemand_data *ondemand_data;
>          struct devfreq_passive_data *passive_data;
...