linux-kernel - Re: [PATCH] dmaengine: qcom-bam-dma: add __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160706171004.GD12591@localhost>
Date:	Wed, 6 Jul 2016 22:40:04 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Andy Gross <andy.gross@...aro.org>,
	Stanimir Varbanov <stanimir.varbanov@...aro.org>,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom-bam-dma: add __maybe_unused annotations
 for PM

On Mon, Jul 04, 2016 at 03:14:08PM +0200, Arnd Bergmann wrote:
> The bam_dma driver gained runtime PM support, but that causes build
> warnings whenever CONFIG_PM is disabled:
> 
> drivers/dma/qcom/bam_dma.c:1324:12: error: 'bam_dma_runtime_resume' defined but not used [-Werror=unused-function]
>  static int bam_dma_runtime_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~~~
> drivers/dma/qcom/bam_dma.c:1315:12: error: 'bam_dma_runtime_suspend' defined but not used [-Werror=unused-function]
>  static int bam_dma_runtime_suspend(struct device *dev)
> 
> This removes the incomplete #ifdef guard and instead marks all
> four PM functions as __maybe_unused, which avoids this kind of
> warning.

Applied, thanks

-- 
~Vinod