linux-kernel - Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467828683.8360.36.camel@perches.com>
Date:	Wed, 06 Jul 2016 11:11:23 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mike Marshall <hubcap@...ibond.com>
Cc:	weiyj_lk@....com, Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] orangefs: use vzalloc() instead of
 vmalloc()/memset(0)

On Wed, 2016-07-06 at 14:00 -0400, Mike Marshall wrote:
> Hi Joe...

Hi Mike.

> I looked around at other code to see how they were using vzalloc...
> even if it is just the caller of the function that uses vzalloc, most
> fs's that use vzalloc print an error message when vzalloc fails...

That's incorrect.

There are 72 v.alloc calls in fs/
2 of those calls have a specific OOM message.
There's 1 in reiserfs (old and unsupported) and 1 in orangefs

>  I sure do
> like to follow the flow of our kernel module all in one place
> with the gossip statements...

I don't see how that matters here as there's
already an OOM on v.alloc failure.

cheers, Joe